feat: Range Partitioning FFI#23520
Open
saadtajwar wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
cc @gene-bordegaray ! Thanks again for all of the help reviewing! 😁 🥳 |
saadtajwar
force-pushed
the
saadtajwar/range-partitioning-ffi
branch
from
e7eb901 to
4d95615
Compare
github-actions
Bot
added
physical-expr
saadtajwar
force-pushed
the
saadtajwar/range-partitioning-ffi
branch
from
4d95615 to
89dd04e
Compare
github-actions
Bot
removed
physical-expr
Contributor
Author
|
cc @timsaucer :) |
timsaucer
requested changes
Jul 14, 2026
timsaucer
left a comment
timsaucer
left a comment
Member
There was a problem hiding this comment.
This is an API change since we're changing the signature. Can you please add a short note in the migration guide?
Member
|
Aside from the api change comment, looks good. |
Contributor
Author
|
Thank you @timsaucer - just updated the description regarding the API change! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Exposing range partition metadata via the FFI for external consumers
What changes are included in this PR?
RangePartitioningand added new enum variant for range inFFI_PartitioningFrom->TryFromto utilize the validation forRangePartitioningand modifiedplan_propertiesto matchAre these changes tested?
Yes
Are there any user-facing changes?
Yes, exposing Range partitioning over FFI. This exposes a new
Rangevariant in theFFI_Partitioningenum, which may cause consumers of this enum to add another arm to match statements to handle the new enum. NewFFI_RangePartitioningstruct for theRangevariant.